Add consistency between prettier and eslint#255
Open
PaulRosset wants to merge 2 commits into
Open
Conversation
8086ca8 to
820dd82
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…lint
Description
I've add a
prettier.config.jsfile to be sure that everyone is using the same config to apply prettier on the project.I also added a
comma-dangleproperty on eslint.We also had a problem on a eslint property concerning the
camelcase, so I disabled the 2 lines concerned, because it depends on theci-envpackages. So, we need to edit it first.Motivation and Context
The
yarn lintscript was not working correctly.I also wanted to add
comma-dangleto improve the readability of future pull request.This PR is closely related to the issue #246
Types of changes
Chore
Checklist: