Skip to content

Exit script with error even if token is provided#231

Open
weynsee wants to merge 1 commit into
siddharthkp:masterfrom
weynsee:master
Open

Exit script with error even if token is provided#231
weynsee wants to merge 1 commit into
siddharthkp:masterfrom
weynsee:master

Conversation

@weynsee

@weynsee weynsee commented Jul 12, 2018

Copy link
Copy Markdown

Description

When bundlesize fails a check, exit with status code of 1.

Motivation and Context

In certain CIs, the exit status is used to indicate whether the build succeeded or failed. Currently, if a CI token is provided, the build exits with 0 status code always (even if the check failed) hence some CIs will always mark bundlesize builds as successful.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
    Previously passing builds in CIs will now fail if bundlesize check fails.

Checklist:

  • My code follows the code style of this project. ✅
  • If my change requires a change to the documentation I have updated the documentation accordingly. ✅
  • I have read the CONTRIBUTING document. ✅
  • I created an issue for the Pull Request ✅

@oliverviljamaa

Copy link
Copy Markdown

@siddharthkp Have you considered this PR?

@kefranabg

Copy link
Copy Markdown

Some news on this PR ? bundlesize cannot be used on CI process without this feature 😕

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants