Add minSize option#209
Open
larionov wants to merge 1 commit into
Open
Conversation
|
It's very use useful for controlling the minimum chunk size. Please review PR. We are waiting for this feature. |
|
This is the feature we are waiting for! |
SmolinPavel
approved these changes
May 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
minSize,--min-sizeoption to fail if size of the bundle is too small.Description
Motivation and Context
Fixes #207.
Sometimes it's useful to also have a warning when your bundle suddenly becomes too small, maybe that wasn't intentional.
This crosses a bit into the functional tests realm but this check I think is simple enough and could serve as a sanity check for some hard-to-test changes, like in css bundles, which require visual/screenshot testing that is not always done.
Even if functional tests for your build are implemented I think the name
bundlesizeandmaxSizeoptions do imply that this tool made for the checking all the things about allowed sizes of files, so it makes sense to keep the information about minimal allowed sizes in the same config.Screenshots (if appropriate):
Types of changes