Adding support for condition field#82
Open
ks0m1c wants to merge 3 commits into
Open
Conversation
added 3 commits
October 28, 2022 00:42
Motivation: To pattern match the condition option match to more cleanly ignore the to field Quoting from Erlang OTP team => https://erlangforums.com/t/handling-options-in-erlang-otp-apis/1133 Briefly, the main motivation for avoiding lists unless necessary, is that given the option list [{use_foo,true}, {use_foo,false}] the value of the use_foo is not immediately clear. Existing OTP APIs that use options are not consistent in that regard. With maps, that ambiguity cannot arise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Naive implementation of incorporating conditions for pushing messages to topics.
Current library is built around the to field, however using condition field collides with the 'to' field. As below:
As such to support condition field, I have prevented the merge of the to field
Willing to add in the test cases and update docs if satisfactory.