Restore size-based remote translog flushes - #2
Closed
shourya035 wants to merge 1 commit into
Closed
Conversation
Track remote translog bytes independently of retained generations. Add a dynamic, disabled-by-default cluster setting for opt-in rollout. Limit tracking to Lucene-based engines and bypass the new machinery while disabled. Reset tracking only after successful index commits. Signed-off-by: Shourya Dutta Biswas <114977491+shourya035@users.noreply.github.com>
This was referenced Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Wires byte-based remote-translog flush accounting into the Lucene-based
InternalEngine.cluster.remote_store.translog.track_bytes_since_last_commit.enabledsetting.falsefor an opt-in rollout.writer.commit()path and does not mutate the tracker while the setting is disabled.cluster.remote_store.translog.max_readersas an independent flush trigger.Related issue
Tracks opensearch-project#22802.
Stack
Depends on #1.
Testing
./gradlew :server:test --tests "org.opensearch.index.translog.InternalTranslogManagerTests" --tests "org.opensearch.indices.RemoteStoreSettingsDynamicUpdateTests"./gradlew :server:precommitChecklist