Skip to content

SG-43461 SG-43644 Migrate Flow host support for Nuke#134

Open
yungsiow wants to merge 5 commits into
masterfrom
ticket/sg-43461/migrate-nuke-host
Open

SG-43461 SG-43644 Migrate Flow host support for Nuke#134
yungsiow wants to merge 5 commits into
masterfrom
ticket/sg-43461/migrate-nuke-host

Conversation

@yungsiow

Copy link
Copy Markdown
Contributor

Implement subclass of FlowHost for Nuke (including dependency introspection support)
Instantiate NukeHost instance during engine set up with context is configured with flow integration

yungsiow added 2 commits June 22, 2026 13:09
- added .flake8 config copied from tk-core
- added vim lock files to .gitignore
- implemented NukeHost subclass of FlowHost
NOTE: FlowWrite node will be ported in a separate ticket
- instantiate NukeHost during engine set up
@codecov

codecov Bot commented Jun 22, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 19.89%. Comparing base (4b58294) to head (09b307c).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
engine.py 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #134      +/-   ##
==========================================
- Coverage   20.03%   19.89%   -0.15%     
==========================================
  Files           6        6              
  Lines         549      553       +4     
==========================================
  Hits          110      110              
- Misses        439      443       +4     
Flag Coverage Δ
Linux 18.80% <0.00%> (-0.14%) ⬇️
Python-3.10 19.89% <0.00%> (-0.15%) ⬇️
Python-3.11 19.89% <0.00%> (-0.15%) ⬇️
Python-3.13 19.89% <0.00%> (-0.15%) ⬇️
Python-3.9 19.89% <0.00%> (-0.15%) ⬇️
Windows 18.80% <0.00%> (-0.14%) ⬇️
macOS 17.90% <0.00%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@carlos-villavicencio-adsk carlos-villavicencio-adsk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small suggestion. The rest looks good overall. I didn't checked logic because it's out of my knowledge.

Comment thread python/flowam/host.py

@carlos-villavicencio-adsk carlos-villavicencio-adsk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chenm1adsk chenm1adsk left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a question and a small comment. The rest looks good to me

Comment thread python/flowam/host.py Outdated
Comment thread python/flowam/host.py Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants