Skip to content

SG-43652 [Phase 2] Migrate FlowAM integration#91

Merged
carlos-villavicencio-adsk merged 21 commits into
ticket/SG-43444_medm_migrationfrom
ticket/SG-43652_medm_migration_phase2
Jun 23, 2026
Merged

SG-43652 [Phase 2] Migrate FlowAM integration#91
carlos-villavicencio-adsk merged 21 commits into
ticket/SG-43444_medm_migrationfrom
ticket/SG-43652_medm_migration_phase2

Conversation

@carlos-villavicencio-adsk

@carlos-villavicencio-adsk carlos-villavicencio-adsk commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Base branch #89

Requirements

Same as shotgunsoftware/tk-multi-loader2#145

TODO

  • Analyze flowam_scene_operations hook and see how it can be merged with the existing hooks
  • Test on Maya
  • Review CI
  • Remove tk_core_ref from azure-pipelines.yml

@carlos-villavicencio-adsk carlos-villavicencio-adsk marked this pull request as draft June 19, 2026 21:18
@carlos-villavicencio-adsk carlos-villavicencio-adsk changed the title SG-43652 medm migration phase2 SG-43652 FlowAM migration phase2 Jun 19, 2026
@codecov

codecov Bot commented Jun 22, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 25.00000% with 33 lines in your changes missing coverage. Please review.
✅ Project coverage is 28.73%. Comparing base (9b803dd) to head (b86410d).

Files with missing lines Patch % Lines
python/tk_multi_breakdown2/api/manager.py 20.68% 23 Missing ⚠️
python/tk_multi_breakdown2/file_item_model.py 0.00% 5 Missing ⚠️
python/tk_multi_breakdown2/dialog.py 0.00% 2 Missing ⚠️
python/tk_multi_breakdown2/file_history_model.py 0.00% 2 Missing ⚠️
app.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@                        Coverage Diff                         @@
##           ticket/SG-43444_medm_migration      #91      +/-   ##
==================================================================
- Coverage                           28.76%   28.73%   -0.04%     
==================================================================
  Files                                  19       19              
  Lines                                2263     2290      +27     
==================================================================
+ Hits                                  651      658       +7     
- Misses                               1612     1632      +20     
Flag Coverage Δ
Linux 28.73% <25.00%> (-0.04%) ⬇️
Python-3.10 28.73% <25.00%> (-0.04%) ⬇️
Python-3.11 28.73% <25.00%> (-0.04%) ⬇️
Python-3.13 28.73% <25.00%> (-0.04%) ⬇️
Python-3.9 28.73% <25.00%> (-0.04%) ⬇️
Windows 28.73% <25.00%> (-0.04%) ⬇️
macOS 28.73% <25.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@carlos-villavicencio-adsk carlos-villavicencio-adsk changed the title SG-43652 FlowAM migration phase2 SG-43652 [Phase 2] Migrate FlowAM integration Jun 22, 2026
@carlos-villavicencio-adsk carlos-villavicencio-adsk marked this pull request as ready for review June 22, 2026 20:45
Comment thread python/tk_multi_breakdown2/api/manager.py Outdated

@yungsiow yungsiow left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes look good, thanks Charlie!

@carlos-villavicencio-adsk carlos-villavicencio-adsk merged commit 485af16 into ticket/SG-43444_medm_migration Jun 23, 2026
26 of 27 checks passed
@carlos-villavicencio-adsk carlos-villavicencio-adsk deleted the ticket/SG-43652_medm_migration_phase2 branch June 23, 2026 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants