Skip to content

SG-17742 Attempt to fix the crash issue with Houdini #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
carlos-villavicencio-adsk wants to merge 1 commit into from
Closed

SG-17742 Attempt to fix the crash issue with Houdini #149

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions python/shotgun_model/shotgun_query_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -880,11 +880,15 @@ def __do_depth_first_tree_deletion(self, node):

# delete the child leaves
for index in range(node.rowCount(), 0, -1):
# Use `takeRow` instead of `removeRow` to prevent model from deleting
# the data before we're done using it. takeRow does not free the memory
# but we own the objects and do not keep a reference to it, so garbage
# collection will take care of freeing up the memory for us.
node.takeRow(index - 1)
if sgtk.platform.current_engine().instance_name == "tk-houdini":

Copilot AI May 15, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider caching the result of sgtk.platform.current_engine() before the loop if the engine is not expected to change, to avoid redundant calls on every iteration.

Copilot uses AI. Check for mistakes.
node.removeRow(index - 1)
else:

Copilot AI May 15, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that for non-Houdini engines the intended node.takeRow(index - 1) call is executed as the diff only shows a comment in this branch.

Copilot uses AI. Check for mistakes.
# For every other engine,
# Use `takeRow` instead of `removeRow` to prevent model from deleting
# the data before we're done using it. takeRow does not free the memory
# but we own the objects and do not keep a reference to it, so garbage
# collection will take care of freeing up the memory for us.
node.takeRow(index - 1)

def __remove_unique_id_r(self, item):
"""
Expand Down