Repository navigation
refactor(dev-tooling)!: remove the optional phpactor PHP LSP - #192
Merged
Martin Bens (SpiGAndromeda) merged 2 commits intoOct 11, 2026
Merged
Conversation
The LSP added little for agents next to PHPStan through the `php-tooling` MCP server, and it carried a Python proxy, a root uv project and a separate CI job. Removes `lsp-server-php`, `.lsp.json`, the `lsp_bootstrap.sh`, `lsp_null.sh` and `lsp_proxy.py` scripts, the `lsp-directives.sh` SessionStart hook with its prompts, `docs/lsp.md`, and their tests. The shared `config.sh` drops the `CONFIG_FILE_PREFIX`/`CONFIG_ENV_VAR_PREFIX` branch that only the LSP launcher set. The root `pyproject.toml`, `uv.lock` and the `python` CI job served only the LSP proxy and are removed with it. The `dev-tooling-setting-up` skill no longer configures the LSP. BREAKING CHANGE: dev-tooling no longer registers a PHP language server, and `.lsp-php-tooling.json` and `LSP_PHP_TOOLING_CONFIG` are ignored. Use PHPStan through the `php-tooling` MCP server instead. Co-Authored-By: Claude <noreply@anthropic.com>
Agent Skills ExportBuilt 7 skill packages: |
The release bump for the LSP removal ships in a separate change, so dev-tooling returns to 4.1.1 and plugin-setup to 1.0.3, and their `CHANGELOG.md` entries for 5.0.0 and 1.0.4 are removed. Co-Authored-By: Claude <noreply@anthropic.com>
Martin Bens (SpiGAndromeda)
deleted the
refactor/dev-tooling-remove-lsp
branch
October 11, 2026 22:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the opt-in phpactor language server from
dev-tooling. For agents it added little next to PHPStan through thephp-toolingMCP server, and it needed a Python proxy, a root uv project and a separate CI job.Changes
lsp-server-php/,.lsp.json,shared/lsp_bootstrap.sh,shared/lsp_null.sh,shared/lsp_proxy.py, thelsp-directives.shSessionStart hook with its two prompts, anddocs/lsp.md.hooks/hooks.jsonrunssession-start.shalone.config.sh: drops theCONFIG_FILE_PREFIX/CONFIG_ENV_VAR_PREFIXbranch, which only the LSP launcher set. Edited intemplates/mcp-shared/config.shand synced to the dev-tooling and shopware-env copies.pyproject.toml,uv.lockand thepythonjob inci.ymlexisted only for the LSP proxy tests and are removed.agent-skills-exportkeeps its own uv project and is unaffected.dev-tooling-setting-upskill no longer asks for.lsp-php-tooling.json, checkspython3orphpactor, or runs LSP validation.lsp_bootstrap.bats,lsp_null.batsandlsp_proxy/, and the two LSP-path cases inmcp-shared/config.bats.codex_manifest.batsfolds its LSP-specific cases into the shared-metadata test, which now also compares description and keywords between the Claude and Codex manifests.AGENTS.md,SETUP.mdanddocs/mcp-enforcement.md. The root README drops the🎯 Skillsbadge from dev-tooling's row, since the plugin has noskills/directory.templates/README.mdnow listslaunch.sh,server_run.shandjs_paths.shas dev-tooling-owned.Version bumps and CHANGELOG entries for dev-tooling and plugin-setup are not part of this PR.
Breaking change
dev-tooling no longer registers a PHP language server.
.lsp-php-tooling.jsonandLSP_PHP_TOOLING_CONFIGare ignored; a project that created the file can delete it. PHPStan through thephp-toolingMCP server remains.