[Martin Bens (SpiGAndromeda)]

Rule-catalog corrections, two removals, and a remediation invariant for test-writing, released as 5.2.0. The rule corrections implement the catalog items from #174; the CONV-005 ordering item is withdrawn there with a warning note. The remediation invariant relates to #176, whose structure-churn item stays open.

Rules corrected against what they actually enforce

Each of these rules flagged code the project's own configuration permits, demanded something its cited mechanism does not check, or contradicted its own examples. Each fix quotes the deciding source.

• UNIT-004 — the shared-mock exception is scoped to the namespaces where shopware.createMockWithoutExpectations actually enables it (Shopware\Tests\Unit\, Shopware\Tests\DevOps\, per common.neon:73), and the mock-without-expectations mechanics defer to PHPStan's NoCreateMockWithoutExpectationsRule. A never()/once() pair that pins reachability is carved out with a worked example — the issue text is explicit that no outcome assertion substitutes for it. A "Stub Conversion Gotchas" section quotes the guideline verbatim (->with() exists on mocks only; the replacement type is Foo&Stub, not MockObject), because remediations kept producing stubs that no longer compile.
• CONV-005 — demoted to consider and given a single-category exemption. A class whose methods all belong to one category has no ordering to violate.
• CONV-011 — suppressed for mechanical data-provider expansions, which repeat a shape the provider already documents.
• CONV-014 — a carve-out for position-load-bearing statements, plus a repaired Fix example that previously violated the rule it illustrates.
• CONV-017 — the exemption now requires at least two reads inside the single referencing method observing the same instance; one read is exactly the inline-it case the rule exists for.
• DESIGN-003 — assertion-based comparison and provider scope stated with the guideline quoted verbatim.
• DESIGN-004 — boundary-input carve-out, guideline quoted verbatim.
• UNIT-001 — findings must name the enforcing mechanism from a fixed seven-name vocabulary instead of asserting "this is enforced elsewhere".
• UNIT-003 — defers its stub-typing remainder to the same PHPStan rule as UNIT-004.
• MIGRATION-008 — standalone clarifying comment.

Removed: checks a deterministic gate already runs

Removed	Enforced upstream by
CONV-007 — class-element ordering	php-cs-fixer ordered_class_elements over tests/
MIGRATION-007 — assertEquals discouraged	PHPStan AssertEqualsIsDiscouragedRule, all paths

The unit catalog goes from 44 rules to 43. get_rules(ids=...) returns not-found for either id. Fallout is propagated: the composed class-structure claims name only CONV-005, the migration skill's should-fix example cites CONV-014, the red-team lens shorthand drops UNIT-005 (removed in 4.2.1) and cites CONV-012 where it named MIGRATION-007, and the BATS assertions that pinned CONV-007 behavior retarget onto CONV-005 and CONV-017 while keeping what each test pins.

Remediation invariant

A reviewer's suggested fix could satisfy a structural rule by weakening what the test proves — reorder methods and drop an assertion, rename and retarget one, silence a layout finding by asserting something adjacent. The three reviewing skills' output requirements and the four team-review prompt builders (reviewer, reconcile, red team, defense) now carry the same invariant: a fix never changes what an existing assertion pins, and never introduces an assertion as a means of satisfying a structural, layout, naming, or style constraint. Coverage-gap rules (MIGRATION-008, DESIGN-006, INTEGRATION-007) keep new assertions as the finding's explicit deliverable, deletions ride removed_assertions, and re-expressing the same pinned fact stays legal (CONV-012's assertTrue($a === $b) to assertSame($b, $a)). The migration skill's warnings example now carries empty deleted_methods/removed_assertions, matching CONV-014's reorder-only semantics.

Limits

• The CONV-005 ordering problem is deliberately unfixed. A deterministic method-name classifier was built and withdrawn: against 15,682 real tests/unit method names, 61% fell into the default category, so deterministic category identification is not possible and must not be reattempted. Test-rules catalog rules produce findings that cannot be applied as written #174 documents this under the CONV-005 bullet.
• INTEGRATION-006's relation to the invariant is unresolvable from its rule file — its Fix example elides the code that would decide it.

[github-actions]

Agent Skills Export

Built 7 skill packages:

• release-info-writing
• adr-writing
• pr-description-writing
• structuring-documentation
• commit-message-writing
• feature-branch-pr-writing
• ci-log-interpretation