Add windows binary#1150
Open
Tobias Schäfer (tschaefermedia) wants to merge 2 commits into
Open
Conversation
Signal(SIGTERM) and Signal(0) return errors on windows, breaking worker --graceful-stop-limit. Split the graceful-stop logic into platform files: unix keeps SIGTERM-then-kill, windows kills directly.
Add windows amd64/arm64 targets (386 excluded, like linux) and package them as zip archives.
Member
|
Hey, Whats the intention here? Run the binary on Windows native and Shopware runs in Docker? Because for me this is kinda just tip of the "iceberg", from my experiences of past PHP on Windows is kinda really bad supported and involves a lot of hassle |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Windows support
Adds Windows as a release target and fixes the one runtime path that broke on Windows.
Why
No Windows binary was ever published. I personally know some developers building extensions on Windows, so having a windows bianry to use would be nice here.
Not changed (verified fine on Windows)
root.goandproject_image_proxy.goregisterSIGINT/os.Interrupt(delivered on Ctrl+C on Windows) alongsideSIGTERM. Ctrl+C cleanup works as-is.Known limitations
--graceful-stop-limitdegrades to an immediate kill on Windows.windows-latestyet. CI is still Linux-only, so nothing guards against future Windows regressions. Should I add this as well?