Repository navigation
fix: spans with conflicting names are not tracked - #20
Merged
Merged
Conversation
Andrii Havryliuk (h1k3r)
requested review from
Ghaith (Gaitholabi) and
Soner (shyim)
and removed request for
Ghaith (Gaitholabi)
September 16, 2025 19:49
Ghaith (Gaitholabi)
approved these changes
Sep 17, 2025
7 tasks
Soner (shyim)
approved these changes
Sep 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Why is this change necessary?
See shopware/shopware#12385
2. What does this change do, exactly?
Changes tracking of spans:
array<string, SpanInterface>witharray<string, SpanInterface[]>for spans stack3. Describe each step to reproduce the issue or behaviour.
Before fix:

After:

4. Please link to the relevant issues (if any).