Skip to content

remove usage of bidfactory - assigns random number for adId which…#1

Open
shlomisut wants to merge 2 commits into
masterfrom
shlomis/fix_request_id
Open

remove usage of bidfactory - assigns random number for adId which…#1
shlomisut wants to merge 2 commits into
masterfrom
shlomis/fix_request_id

Conversation

@shlomisut

@shlomisut shlomisut commented Apr 17, 2019

Copy link
Copy Markdown
Owner

… causes some prebid wrappers to fail (namely yormedia)

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

  • test parameters for validating bids
{
  bidder: '<bidder name>',
  params: {
    // ...
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

… causes some prebid wrappers to fail (namely yormedia)
@shlomisut

Copy link
Copy Markdown
Owner Author

@borisjaskerovich

Comment thread modules/timBidAdapter.js
var responseCPM;
var placementCode = '';
if (bidRequest) {
var bidResponse = bidfactory.createBid(1);

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the bidfactory does this assignment this.adId = utils.getUniqueIdentifierStr(); which cause issues with yorMedia wrapper

Comment thread modules/timBidAdapter.js
var responseCPM = parseFloat(bidderBid.price);
if (responseCPM === 0) {
var bid = bidfactory.createBid(2);
var bid = bidfactory.createBid(2, bidRequest);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i see you are still using bidfactory

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only when no-bid

Comment thread modules/timBidAdapter.js
var responseCPM = parseFloat(bidderBid.price);
if (responseCPM === 0) {
var bid = bidfactory.createBid(2);
var bid = bidfactory.createBid(2, bidRequest);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bidfactory.createBid(2, bidRequest);
what does it do?

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

creates an empty bid with some values based on the bidrequest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants