Skip to content

Revert "Simplify Open function by removing error check" #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shivang-16 merged 1 commit into from
Aug 29, 2026
Merged

Revert "Simplify Open function by removing error check" #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions internal/infra/postgres/postgres.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,27 +17,38 @@ type Client struct {

func Open(cfg config.Postgres) (*Client, error) {
db, err := sql.Open("pgx", cfg.DSN())
if err != nil {
return nil, fmt.Errorf("open postgres: %w", err)
}

maxOpen := cfg.MaxOpenConns
if maxOpen < 1 {
maxOpen = 10
}
maxIdle := cfg.MaxIdleConns

if maxIdle < 1 {
maxIdle = 5
}
db.SetMaxOpenConns(maxOpen)
db.SetMaxIdleConns(maxIdle)
db.SetConnMaxLifetime(time.Hour)

ctx, cancel := context.WithTimeout(context.Background(), 5*time.Second)
defer cancel()


if err := db.PingContext(ctx); err != nil {
_ = db.Close()
return nil, fmt.Errorf("ping postgres: %w", err)
}

return &Client{db: db}, nil
}

func OpenAndMigrate(cfg config.Postgres, migrationsDir string) (*Client, error) {
client, err := Open(cfg)
if err != nil {
return nil, err
}

ctx, cancel := context.WithTimeout(context.Background(), 10*time.Second)
defer cancel()
Expand Down
Loading