Skip to content

Simplify Open function by removing error check #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shivang-16 merged 3 commits into from
Aug 29, 2026
Merged

Simplify Open function by removing error check #2

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8c7a07c
Simplify Open function by removing error check
shivang-16 Aug 29, 2026
8c035f6
Update postgres.go
shivang-16 Aug 29, 2026
456c3f9
Update postgres.go
shivang-16 Aug 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 2 additions & 13 deletions internal/infra/postgres/postgres.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
import (
"context"
"database/sql"
"fmt"

Check failure on line 6 in internal/infra/postgres/postgres.go

View workflow job for this annotation

GitHub Actions / Test 

"fmt" imported and not used
"time"

_ "github.com/jackc/pgx/v5/stdlib"
Expand All @@ -16,39 +16,28 @@
}

func Open(cfg config.Postgres) (*Client, error) {
db, err := sql.Open("pgx", cfg.DSN())

Check failure on line 19 in internal/infra/postgres/postgres.go

View workflow job for this annotation

GitHub Actions / Test 

declared and not used: err
if err != nil {
return nil, fmt.Errorf("open postgres: %w", err)
}

maxOpen := cfg.MaxOpenConns
if maxOpen < 1 {
maxOpen = 10
}
maxIdle := cfg.MaxIdleConns
if maxIdle < 1 {
maxIdle = 5
}

db.SetMaxOpenConns(maxOpen)
db.SetMaxIdleConns(maxIdle)
db.SetConnMaxLifetime(time.Hour)

ctx, cancel := context.WithTimeout(context.Background(), 5*time.Second)

Check failure on line 31 in internal/infra/postgres/postgres.go

View workflow job for this annotation

GitHub Actions / Test 

declared and not used: ctx
defer cancel()

if err := db.PingContext(ctx); err != nil {
_ = db.Close()
return nil, fmt.Errorf("ping postgres: %w", err)
}


return &Client{db: db}, nil
}

func OpenAndMigrate(cfg config.Postgres, migrationsDir string) (*Client, error) {
client, err := Open(cfg)

Check failure on line 40 in internal/infra/postgres/postgres.go

View workflow job for this annotation

GitHub Actions / Test 

declared and not used: err
if err != nil {
return nil, err
}

ctx, cancel := context.WithTimeout(context.Background(), 10*time.Second)
Comment on lines 40 to 42

@beetle-ai beetle-ai Bot Aug 29, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the error check after Open(cfg) creates a nil pointer dereference vulnerability. If Open() returns an error, client will be nil, but the code continues executing and will crash when attempting to use client in subsequent operations.

Confidence: 5/5

Suggested Fix
Suggested change
client, err := Open(cfg)
if err != nil {
return nil, err
}
ctx, cancel := context.WithTimeout(context.Background(), 10*time.Second)
func OpenAndMigrate(cfg config.Postgres, migrationsDir string) (*Client, error) {
client, err := Open(cfg)
if err != nil {
return nil, err
}
ctx, cancel := context.WithTimeout(context.Background(), 10*time.Second)
defer cancel()

The error check must be restored. The Open() function can fail for various reasons (invalid connection string, database unavailable, etc.), and these errors must be handled before proceeding. Removing this check allows the function to continue with a nil client, which will cause a panic when the client is used.

Prompt for AI

Copy this prompt to your AI IDE to fix this issue locally:

In internal/infra/postgres/postgres.go around line 40, the error check after Open(cfg)
was removed, which creates a nil pointer dereference vulnerability. If Open() returns an
error, the client will be nil but the code continues executing. Restore the error handling
check: if err != nil { return nil, err } immediately after the Open(cfg) call to prevent
crashes when the database connection fails.

📍 This suggestion applies to lines 40-42

defer cancel()
Expand Down
Loading