[MASTER] fix: make this example work for public api - #22
Conversation
| "CLIENT_ID": "996fc83d-97d7-48f1-9638-744d89874a8c", | ||
| "CLIENT_SECRET": "2fd0b7558b43c8b0c078ef2126a79eee336e8f47e0764dd6c5", |
There was a problem hiding this comment.
Are we fine with those ? Shouldn't we use Teller or something ? 👀
There was a problem hiding this comment.
hum yeah I'll remove them. I wanted to make them available for us but I'll write this in a notion page
| "scripts": { | ||
| "local": "nodemon", | ||
| "dev": "API_ENV=staging nodemon", | ||
| "dev:public": "PUBLIC_API=true API_ENV=staging nodemon", |
There was a problem hiding this comment.
Why not make it part of the default yarn dev ?
There was a problem hiding this comment.
it could be part of config. true
| } catch (e) { | ||
| console.error(e); | ||
| } catch (error) { | ||
| console.error('Error retrieving tokens ⛔️', error); |
There was a problem hiding this comment.
💅 I'm not a huge fan of logs containing emojis if they end up in an actual logging system (#Datadog) 🫣
I can see the previous logs with some, but just sayin' 😁
There was a problem hiding this comment.
this project purpose is to help partner to integrate shine connect. this is an example of how to implement the api calls and the result of some endpoints
| @@ -0,0 +1,29 @@ | |||
| export const minimalScopes = ['openid', 'profile', 'user:profile:read']; | |||
|
|
|||
| export const availableScopes = { | |||
There was a problem hiding this comment.
I don't have any context about this, so I trust you.
For my knowledge though: are those bound to be kept in sync with another system ? If that's the case, are those gonna end up being pulled automatically in the future ?
5e2abd2 to
0116f87
Compare
0116f87 to
d71e76c
Compare
2 participants
Uh oh!
There was an error while loading. Please reload this page.