Preserve subprocess_create failure error details#96
Merged
Conversation
🧙 Conjured by AI via [pi.dev](https://pi.dev/) using gpt-5.5
🧙 Conjured by AI via [pi.dev](https://pi.dev/) using gpt-5.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #50.
This keeps
subprocess_create*success behavior unchanged (0means success), and gives non-zero returns a documented portable meaning via the newenum subprocess_error_e:subprocess_error_not_foundsubprocess_error_permission_deniedsubprocess_error_no_memorysubprocess_error_invalid_optionssubprocess_error_invalid_environmentsubprocess_error_pipesubprocess_error_spawnsubprocess_error_unknownIt also preserves the platform-specific failure detail so callers can report richer diagnostics:
errnois restored after cleanup.GetLastError()is restored after cleanup.Added docs and a regression test for a missing executable returning
subprocess_error_not_foundwhile preservingENOENT/ERROR_FILE_NOT_FOUND.Local verification:
Both test binaries pass locally: 48/48 each.
🧙 Conjured by AI via pi.dev using gpt-5.5