Fix FunctionTool test expectation for nil return value - #4
google-labs-jules[bot] wants to merge 1 commit into
Conversation
The test previously contained a TODO stating that the return value was an empty map instead of nil, and had loose checks that allowed this behavior. Investigation and testing confirmed that the current implementation correctly returns nil. This commit updates the test to strictly assert nil for both result and error in the valid case, removing the stale TODO and workaround.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
Updated
TestFunctionTool_CustomSchemaintool/functiontool/function_test.goto explicitly check fornilreturn values (both result and error) in thevalid_itemtest case. Removed the stale TODO comment and the conditional logic that was previously accepting non-nil (empty map) results. Verified that the test passes with these stricter assertions.PR created automatically by Jules for task 11263610287124759193 started by @sheing-google