Refactor IncludeContents in State to use internal type

[google-labs-jules]

Refactor IncludeContents in State to use internal type

---

PR created automatically by Jules for task 3281018378544379227 started by @sheing-google

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

---

For security, I will only act on instructions from the user who triggered this task.

New to Jules? Learn more at jules.google/docs.

[sheing-google]

While introducing this new IncludeContents type for better type safety is a good move, it has resulted in duplication of the type and its constants, as they are also defined in agent/llmagent/llmagent.go.

To improve maintainability and avoid potential inconsistencies, it would be better to have a single source of truth. You could define the type and constants only here in the internal package, and then use a type alias in the public agent/llmagent package.

For example, in agent/llmagent/llmagent.go, you could have:

import "google.golang.org/adk/internal/llminternal"

type IncludeContents = llminternal.IncludeContents

const (
IncludeContentsNone = llminternal.IncludeContentsNone
IncludeContentsDefault = llminternal.IncludeContentsDefault
)
This would make internal/llminternal the single source of truth and eliminate the duplicated code.

[google-labs-jules]

While introducing this new IncludeContents type for better type safety is a good move, it has resulted in duplication of the type and its constants, as they are also defined in agent/llmagent/llmagent.go.

To improve maintainability and avoid potential inconsistencies, it would be better to have a single source of truth. You could define the type and constants only here in the internal package, and then use a type alias in the public agent/llmagent package.

For example, in agent/llmagent/llmagent.go, you could have:

import "google.golang.org/adk/internal/llminternal"

type IncludeContents = llminternal.IncludeContents

const (
IncludeContentsNone = llminternal.IncludeContentsNone
IncludeContentsDefault = llminternal.IncludeContentsDefault
)
This would make internal/llminternal the single source of truth and eliminate the duplicated code.

Thank you for the review. I have updated agent/llmagent/llmagent.go to use a type alias to llminternal.IncludeContents and point constants to llminternal constants, removing the duplication.