fix(adkrest): Prevent panic in SSE handler when LLM returns an error - #17
google-labs-jules[bot] wants to merge 1 commit into
Conversation
The `RunSSEHandler` in the adkrest server would panic if the `r.Run` method returned an error. This was because the `continue` statement in the error handling block would cause the loop to continue and attempt to dereference a nil `event`. This change replaces the `continue` statement with `return nil`, which correctly terminates the handler after sending the error message to the client. A new test case has been added to `runtime_test.go` to simulate this error condition and ensure the handler does not panic. The test has been refactored to use `httptest.NewServer` to properly test the SSE handler's behavior, including write deadlines.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
|
review |
1 participant
This change fixes a panic in the adkrest server's SSE handler that occurred when the underlying LLM call returned an error. The panic was caused by a
continuestatement that allowed the handler to attempt to process a nil event. The fix replaces thecontinuewith areturn nil, ensuring the handler gracefully terminates the connection after sending the error to the client. A new test case has been added to verify this behavior and prevent future regressions.PR created automatically by Jules for task 3007906178804049364 started by @sheing-google