ENH: Allows to add rooms by specifying a string#13
Open
quazgar wants to merge 2 commits intoshawnanastasio:masterfrom
Open
ENH: Allows to add rooms by specifying a string#13quazgar wants to merge 2 commits intoshawnanastasio:masterfrom
quazgar wants to merge 2 commits intoshawnanastasio:masterfrom
Conversation
|
Look at my PR, its logic is slightly better. If rooms specified, bot will be exclusive anyway. If not specified, bot will be listening on all of its rooms. Accept invites is the separated option. |
Owner
|
Hi @quazgar, thanks for the PR (and sorry for the late response)! I think the ability to specify rooms by ID string is a useful feature, and your implementation looks good to me. I'm not sure about the usefulness of the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's also a new keyword arg for MatrixBotAPI:
exclusive_rooms=Truetells only the specified rooms should be used, all others will be left.