docs(skill): document oc_journal_compact cadence and pin round-trip stability#1444
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
…tability Add docs/skills/trajectory-compaction.md describing recommended compaction cadence (every 20–50 steps), strategy selection (recent_k / checkpoint_only / sampling), and composition with the LLM-free fast path (#1430 Part 2). Add round-trip integration test that pins the lossy-but-stable contract: two consecutive compactions over the same trajectory must agree on open_assertions, last_checkpoint, and (for deterministic strategies) the summary text. Without this gate, a future refactor of the truncation logic could silently destabilise resume flows. Part 2 of #1434. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
8abecc2 to
68e9a83
Compare
Goal-review verdict — #1444Intent vs SSOT (#1359)
Code-level review
CI fixes applied (rebased on the updated parent)
StatusMerge-ready pending parent #1442 landing. No further changes to this PR's own diff. |
…nce doc Adds a third round-trip case asserting that strategy:'sampling' returns status:'unsupported_by_host' with no fabricated summary when the host lacks the sampling capability — the exact #1359 guarantee (never server-side) that was previously only asserted in prose. Also softens the cadence table to keep the 20/50-step figures attributed to Webwright rather than implying an OpenChrome-measured benchmark (#1359 P5). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Review analysis — merge-readinessIntent & direction. Part 2 of #1434: documents the #1359 alignment — PASS. The docs correctly describe the Findings & fixes applied this pass:
Tests: Merge logistics (the one real blocker for Verdict: content MERGE-READY; landing on |
Summary
Stacked on #1442 (Part 1).
docs/skills/trajectory-compaction.md: cadence table (20–50 step), strategy selection, composition with the LLM-free fast path (docs(skill): document LLM-free recall→precheck→replay fast path #1443).tests/tools/oc-journal-compact-roundtrip.test.ts: pins the lossy-but-stable contract — two consecutive compactions agree on open_assertions, last_checkpoint, and (deterministic strategies) the summary text; plus a sampling-unsupported case pinning the SSOT: OpenChrome as a host-neutral MCP browser harness #1359 "never server-side" guarantee.Test plan
Review-pass changes
status:'unsupported_by_host'with no fabricated summary).Part 2 of #1434. Depends on #1442.
Co-Authored-By: Claude Opus 4.7 (1M context) noreply@anthropic.com