Repository navigation
Integrate auth/og fixes + dashboard redesign with origin/main - #4
Merged
Merged
Conversation
# Conflicts: # launch-checklist.md
Aurora probes for a WebGL context before constructing the ogl Renderer so the landing page no longer throws when WebGL is unavailable (headless browsers, disabled HW acceleration, GPU blocklist). A new hydrated reduced-motion hook returns a stable value through SSR and the first client render, eliminating a matchMedia-driven hydration mismatch in the scroll animation. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
normalizeAuthNextPath rejected a leading '//' but the URL parser collapsed '/..//evil.com' into a protocol-relative '//evil.com' pathname that survived the same-origin check, letting /auth/callback?next=... redirect users off-site after a legitimate sign-in. Reject any resolved path that is still protocol-relative, with a regression test for the collapse cases. Point metadataBase at NEXT_PUBLIC_SITE_URL (fallback https://motioncode.live) instead of the dead motioncode.vercel.app preview domain, so the generated Open Graph / Twitter image resolves on the live host. Drop the redundant manual openGraph.images entry; the app/opengraph-image.tsx file convention is the single source. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
# Conflicts: # app/dashboard/page.tsx # components/dashboard/app-shell.tsx # components/dashboard/login-form.tsx # tests/e2e/app-smoke.spec.ts # tests/e2e/auth-dashboard.spec.ts # tests/unit/auth-dashboard-pages.test.ts # tests/unit/auth-redirects.test.ts # tests/unit/login-form.test.tsx
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
The marketing spec still asserted the pre-redesign landing: a "TRUSTED BY DEVELOPERS AT" kicker and partner logos exposed via accessible img roles. The redesigned strip uses the kicker "Fits beside the tools motion teams already use" and renders logos as decorative (alt="" aria-hidden), so the old assertions failed. Update the kicker assertion and match each brand by its simpleicons CDN source instead of an accessible name. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Lands the issues found during the live-site + code deep-dive, and integrates the 3-day divergence between
origin/mainand the unpushed dashboard-redesign work so productionmainhas both.Fixes
lib/auth/redirects.ts):normalizeAuthNextPathrejected a leading//but the URL parser collapsed/..//evil.cominto a protocol-relative//evil.compathname that survived the same-origin check, so/auth/callback?next=…(and/login?next=…) could redirect a user off-site after a legitimate sign-in. Now rejects any resolved path that is still protocol-relative, with regression tests for the..//,./..//, and/\collapse cases.app/layout.tsx):metadataBasepointed at the deadmotioncode.vercel.apppreview domain, so every OG/Twitter image URL 404'd. Now usesNEXT_PUBLIC_SITE_URL(fallbackhttps://motioncode.live) and drops the redundant manualopenGraph.imagesentry — theapp/opengraph-image.tsxfile convention is the single source.Renderer(no more crash when WebGL is unavailable — headless browsers, GPU blocklist, HW accel off); a new hydrated reduced-motion hook returns a stable value through SSR + first client render, removing amatchMediahydration mismatch.Merge integration (origin/main ↔ dashboard redesign)
origin/main(Jun 11) hadfeat: route auth into app and gate free projects(free-project-cap migration +paidOnlydashboard gating) andfix: guard google oauth provider state. Local main (Jun 14, never pushed) had the dashboard redesign. This branch merges both. Conflict resolutions:app/dashboard/page.tsx— kept origin'spaidOnly: truegating.components/dashboard/app-shell.tsx— kept the newer redesigned shell (header nav + dedicated/projects/workspacesroutes).auth-dashboard-pages.test.ts— kept origin's added callback test.login-form.test.tsx— kept the redesign's test structure (the merged login-form has the Google provider check, so tests mustsettleProviderCheck(); origin's pre-redesign duplicate was dropped).Verification
npm run typecheck— cleannpm run lint— cleannpm test— 176 passed (27 files)npm run build— succeeds (full route manifest generated)🤖 Generated with Claude Code