[feat]: improve email validation in backend verifier to prevent malform…#87
Open
Denisha227 wants to merge 1 commit into
Open
[feat]: improve email validation in backend verifier to prevent malform…#87Denisha227 wants to merge 1 commit into
Denisha227 wants to merge 1 commit into
Conversation
|
@Denisha227 is attempting to deploy a commit to the Vaibhav Sharma's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Previously, the backend email verifier used a very basic check (if not email or "@" not in email:) to check for valid emails. This allowed invalid or malformed email patterns (such as missing a top-level domain, local-part, or containing invalid characters) to pass through to the subsequent SMTP verification steps, wasting connection bandwidth and server resources.
This PR improves the email verification process by introducing a lightweight, robust regular expression check before SMTP verification.
Key Changes
Regex-Based Check: Added a structured regex pattern (^[a-zA-Z0-9._%+-]+@[a-zA-Z0-9.-]+.[a-zA-Z]{2,}$) in contact-discovery-service/verifier.py.
Early Rejection: Ensures malformed email formats (e.g., user@, user@domain, @domain.com, user@domain.) are instantly marked as "invalid" and rejected without triggering unnecessary rate limit checks or DNS/SMTP lookups.
Maintainability: Kept the regular expression lightweight to balance performance and coverage.