Auto-forward Order-typed ctx parameter as bit_order#660
Open
sachaw wants to merge 2 commits into
Open
Conversation
Contributor
|
Not really a comment of substance, but: struct Parent { right: Child, left: Child }it seems like an odd choice to put the variable called |
Author
|
lol, good catch. |
Author
|
hey, any change I get get this merged, I have some other PR's to file afterwards. |
wcampbell0x2a
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I hit the following issue in one of my projects.
When a nested struct/enum receives bit ordering via
ctx = "o: Order", it currently has to also setbit_order = "o"for that order to be applied — otherwise thectxparameter is silently ignored and codegen falls back to msb.#602 hit this and was closed pointing to that duplicate-attribute workaround; this PR forwards an
Order-typedctxparameter as the runtimebit_orderautomatically when no explicitbit_orderis given.Repro (against 0.20.3)