Avoid allocating in ReadExact when insufficient data#659
Open
fbergero wants to merge 1 commit into
Open
Conversation
Author
|
@sharksforarms Hey idk what's your AI policy for contributions, but feel free to drop this PR if it's against the policy |
086c9ab to
b782745
Compare
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> AI-Attribution: AI:0,Human:140,Tool:none
b782745 to
502538e
Compare
wcampbell0x2a
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DekuReader<ReadExact> for Vec<u8>to verify the underlying reader has enough bytes before allocating the output bufferreader.as_mut()to seek on the inner reader directly, avoiding side effects onReader'sbits_readandleftoverstateDekuError::Incompleteearly when data is insufficientProblem
The current implementation unconditionally allocates and zero-fills a buffer of
exact.0bytes:If
exact.0comes from untrusted input (e.g., a length-prefixed protocol), a malformed value can cause a huge allocation that gets immediately discarded whenread_bytesfails. This is a DoS vector for any binary parser handling network data.Fix
Three cheap seeks (get position, seek to end, restore) to compute remaining bytes, then early-return
Incompleteif insufficient. Zero overhead for the happy path beyond those seeks.Tests
alloc_counter(existing dev-dependency) that proves(0, 0, 0)allocations on the error path withReadExact(1_000_000)on a 3-byte bufferTest plan
🤖 Generated with Claude Code