Repository navigation
fix: default to 125 GiB GPU memory on 128 GiB nodes - #9
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Raise the calculated GPU wired-memory ceiling introduced in #5 so a 128 GiB inference node defaults to 125 GiB instead of 118 GiB.
Explicit
gpu_memory_gboverrides remain unchanged. Update the configuration error, README and example configuration to match.Evidence
After: executable shell fixtures verify 125/61 GiB, an unchanged 125 GiB limit without a redundant write, an 8 GiB host, and rejection at or below 3 GiB. Existing explicit-override and write/readback failure coverage remains intact.
make dev-check: 407 passed, Ruff passed, using an ignored local copy oftfconfig.example.yamlastfconfig.yamlfor the status tests.git diff --checkpassed.Merge Danger
Door: two-way
To restore the previous ceiling on a 128 GiB node, set
gpu_memory_gb: 118and reinstall/restart the managed daemon.Blast Radius: inference-hosts
The next managed daemon installation/restart applies RAM minus 3 GiB wherever the calculated default is selected, including nodes of other sizes. At full GPU use, only 3 GiB remains outside this host-wide ceiling, increasing memory-pressure/swap risk. This is a ceiling, not a reserved allocation; oMLX memory-guard settings remain independent and may impose a lower limit. Merging alone does not change installed daemons.