Repository navigation
test: isolate cluster status tests from repo tfconfig - #10
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The five
test_cluster_status_*tests invokecluster statuswithout a config, so the CLI's_load_config()resolves the repo-roottfconfig.yaml— an untracked file that exists on the rock deployment but not in CI. Every PR has been failing CI on these 5 tests since the status display work (main is red too, e.g. runs 39378563747/39374362916).Fix follows the file's existing convention (
test_runtime_start_dry_run_omits_default_model_dir): a_use_tmp_tfconfig()helper writes a minimalmodels: {}\nnodes: {}tfconfig intotmp_pathand pointsfind_repo_rootat it. Two tests that lackedtmp_pathgained the fixture parameter.Evidence
tfconfig.yamlhidden (CI condition): 407 passed.ruff check: clean.