Skip to content

test: isolate cluster status tests from repo tfconfig - #10

Merged
sg-shag merged 1 commit into
mainfrom
test/cluster-status-tmp-tfconfig
Oct 28, 2026
Merged

sg-shag merged 1 commit into
mainfrom
test/cluster-status-tmp-tfconfig

Conversation

@sg-shag

@sg-shag sg-shag commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

Summary

The five test_cluster_status_* tests invoke cluster status without a config, so the CLI's _load_config() resolves the repo-root tfconfig.yaml — an untracked file that exists on the rock deployment but not in CI. Every PR has been failing CI on these 5 tests since the status display work (main is red too, e.g. runs 39378563747/39374362916).

Fix follows the file's existing convention (test_runtime_start_dry_run_omits_default_model_dir): a _use_tmp_tfconfig() helper writes a minimal models: {}\nnodes: {} tfconfig into tmp_path and points find_repo_root at it. Two tests that lacked tmp_path gained the fixture parameter.

Evidence

  • Full suite with repo-root tfconfig.yaml hidden (CI condition): 407 passed.
  • Full suite with it restored: 407 passed.
  • ruff check: clean.

@coderabbitai

coderabbitai Bot commented Oct 28, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 4d675f5b-4395-4071-9fd6-38c197ecd224
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sg-shag
sg-shag merged commit dc4ea55 into main Oct 28, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant