Skip to content

fix issue #22 (App crash when trying to close shell) #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bodaghialib4 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix issue #22 (App crash when trying to close shell) #42

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions android/src/main/java/com/reactlibrary/RNSshClientModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,15 @@ public void run() {
client._dataOutputStream = new DataOutputStream(channel.getOutputStream());

callback.invoke();
} catch (JSchException error) {
Log.e(LOGTAG, "Error starting shell: " + error.getMessage());
callback.invoke(error.getMessage());
} catch (IOException error) {
Log.e(LOGTAG, "Error starting shell: " + error.getMessage());
callback.invoke(error.getMessage());
}

try {
// int charVal;
String line;
while (client._bufferedReader != null && (line = client._bufferedReader.readLine()) != null) {
Expand All @@ -193,11 +201,9 @@ public void run() {
}

} catch (JSchException error) {
Log.e(LOGTAG, "Error starting shell: " + error.getMessage());
callback.invoke(error.getMessage());
Log.e(LOGTAG, "Error reading shell output: " + error.getMessage());
} catch (IOException error) {
Log.e(LOGTAG, "Error starting shell: " + error.getMessage());
callback.invoke(error.getMessage());
Log.e(LOGTAG, "Error reading shell output: " + error.getMessage());
}
}
}).start();
Expand Down