Skip to content

fix: reject non-YT video IDs before hitting upstream API #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shanehull merged 1 commit into from
Jun 16, 2026
Merged

fix: reject non-YT video IDs before hitting upstream API #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions cmd/server/main_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,3 +61,15 @@ func TestNotFound(t *testing.T) {
t.Fatalf("got status %d, want 404", rec.Code)
}
}

func TestInvalidVideoID(t *testing.T) {
t.Parallel()
h := newTestHandler(t)
req := httptest.NewRequest(http.MethodGet, "/favicon.png", nil)
rec := httptest.NewRecorder()
h.ServeHTTP(rec, req)

if rec.Code != http.StatusBadRequest {
t.Fatalf("got status %d, want 400", rec.Code)
}
}
7 changes: 5 additions & 2 deletions internal/handlers/handlers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import (
"html/template"
"log/slog"
"net/http"
"regexp"
"strings"

yt "github.com/shanehull/yt-transcript"
Expand Down Expand Up @@ -132,6 +133,8 @@ type pageData struct {
Version string
}

var videoIDRe = regexp.MustCompile(`^[A-Za-z0-9_-]{11}$`)

var indexPage = template.Must(template.New("index").Parse(indexHTML))

// Healthz returns a 200 OK status for health checks.
Expand Down Expand Up @@ -160,8 +163,8 @@ func Index(baseURL, version string) http.Handler {
func Transcript(client *yt.Client, transcriptCache *cache.Cache) http.Handler {
return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
videoID := r.PathValue("video_id")
if videoID == "" {
writeError(w, http.StatusBadRequest, "missing video_id")
if videoID == "" || !videoIDRe.MatchString(videoID) {
writeError(w, http.StatusBadRequest, "invalid video_id")
return
}

Expand Down