Skip to content

Untrimmed BMW names from older psdzdata: 149 new CAFD ids, plus a pack-caf command - #4

Merged
shamair28 merged 4 commits into
shamair28:mainfrom
iambak:add-untrimmed-names-from-old-psdzdata
Nov 18, 2026
Merged

shamair28 merged 4 commits into
shamair28:mainfrom
iambak:add-untrimmed-names-from-old-psdzdata

Conversation

@iambak

@iambak iambak commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

First, thank you for building this. I had been planning to make something very similar myself, and when I found Open CAFD Map already doing it (and doing it well), contributing here made a lot more sense than starting a second project.

What this adds

BMW's untrimmed names from older psdzdata and a CAFD dump I had, packed into definitions/untrimmed/.

Before After Added
CAFD ids with BMW names 164 313 +149
Group names 5,429 9,543 +4,114
Function names 148,618 248,830 +100,212
Value names 273,593 530,396 +256,803
Package size 2.8 MB 5.2 MB +2.4 MB

Most of the new ids are older F-series ECUs (F001, F010, F025, F015, F045, F056), plus I001, K001/KE01, RR01/RR11 and some early G-chassis ECUs (G011, G030, G038, G001). I have not recomputed the coverage chart: its denominators come from your psdzdata, so those numbers are yours to regenerate.

Commits

  1. pack-caf command in ocm/untrimmed.py (+ one sentence in CONTRIBUTING.md). pack-dumps only reads <CafdDefinition> dumps, and build_defdb.py skips function and value names, so there was no way to pack names from a psdzdata that still carries them. pack-caf reads decrypted <caf> XML directly and uses the existing merge, so the rules are unchanged: existing names win and nothing is removed.
  2. Names from PSdZData 52.1 and 2.54 (2014): 1,964 and 2,253 decrypted CAFDs, 124 new CAFD ids.
  3. Names from a 2008-2016 untrimmed CAFD dump: 1,356 CAFDs (259 ids), 25 new CAFD ids. Kept as its own commit in case you want to take it separately.

Only the packed .tsv.gz name files are included: no psdzdata, decrypted files, NCDs or VINs.

Checks

  • python ocm/check_names.py: 0 errors (the 5 warnings are existing ones in community-cheatsheets).
  • Every row that was already in the 100 updated packages is still there, unchanged.
  • Re-running pack-caf on the three sources from a clean checkout of main gives byte-identical packages.
  • Not run: check_names.py --db (I have no built definition DB on this machine).

One thing worth knowing

In about 60 of the ids you already had, the 2014 files name some functions differently from your packages for the same datagroup layout (same address and layout hash). The cases I looked at are BMW renaming or assigning bits between software versions: for example a bit your package calls UNBELEGT is CDMM_USB_COVER_ART in older HU_CICHB versions. Since existing names win, your names are kept and the older ones are dropped, so nothing changes for current users. It does mean a layout hash alone cannot tell those versions apart, in case that matters for older cars.

Happy to split this up, drop the third commit, or change anything about pack-caf if you would prefer it done differently.

🤖 Generated with Claude Code

iambak and others added 4 commits November 18, 2026 22:43
pack-dumps only reads CafdDefinition dumps. pack-caf reads the <caf> XML of
a psdzdata old enough to still carry its names, so untrimmed names can be
contributed from it with one command. Only names are read; same merge rules
(existing names win, nothing is removed).

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Packed with pack-caf from 1,964 (52.1) and 2,253 (2.54) decrypted CAFDs.
164 -> 288 CAFD ids, 148,618 -> 222,677 function names,
273,593 -> 460,904 value names. Mostly F001/F010/F025/F015/F045/F056,
plus I001, K001/KE01 and RR01 ECUs. No existing row changed.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Packed with pack-caf from an untrimmed CAFD dump (1,356 CAFDs, 259 ids).
288 -> 313 CAFD ids, 222,677 -> 248,830 function names,
460,904 -> 530,396 value names. Adds early G-chassis ECUs
(G011, G030, G038, G001) and RR11.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
From `python ocm/untrimmed.py stats`. The coverage chart and the 89% figure
are left alone: they need a rebuild against current psdzdata.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@shamair28
shamair28 merged commit b4cefe6 into shamair28:main Nov 18, 2026
@shamair28

Copy link
Copy Markdown
Owner

Thank you, this is a great contribution! Merged, and the new names are already out to everyone as definitions 2026.11.18.1 through Check for updates. The pack-caf command is a really useful addition too. Good catch on older versions renaming bits within the same layout, I'll keep that in mind for older cars.

shamair28 added a commit that referenced this pull request Nov 18, 2026
…11.18.1)

Recounted per main series from the CAFD ids in psdzdata after PR #4's packages (313 CAFD ids):
G-chassis 67% -> 84% of CAFD ids (120 of 143), F-chassis 52% -> 94% (240 of 254); F001, F010, F025
and F030 at 100%. Verified functions across every G020 and F030 version: about 89% -> 92%
(G020 89.3%, F030 97.0%, from definition DBs rebuilt with the new packages).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
shamair28 added a commit that referenced this pull request Nov 18, 2026
…11.18.1)

Recounted per main series from the CAFD ids in psdzdata after PR #4's packages (313 CAFD ids):
G-chassis 67% -> 84% of CAFD ids (120 of 143), F-chassis 52% -> 94% (240 of 254); F001, F010, F025
and F030 at 100%. Verified functions across every G020 and F030 version: about 89% -> 92%
(G020 89.3%, F030 97.0%, from definition DBs rebuilt with the new packages).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants