Repository navigation
Untrimmed BMW names from older psdzdata: 149 new CAFD ids, plus a pack-caf command - #4
Merged
shamair28 merged 4 commits intoNov 18, 2026
Conversation
pack-dumps only reads CafdDefinition dumps. pack-caf reads the <caf> XML of a psdzdata old enough to still carry its names, so untrimmed names can be contributed from it with one command. Only names are read; same merge rules (existing names win, nothing is removed). Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Packed with pack-caf from 1,964 (52.1) and 2,253 (2.54) decrypted CAFDs. 164 -> 288 CAFD ids, 148,618 -> 222,677 function names, 273,593 -> 460,904 value names. Mostly F001/F010/F025/F015/F045/F056, plus I001, K001/KE01 and RR01 ECUs. No existing row changed. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Packed with pack-caf from an untrimmed CAFD dump (1,356 CAFDs, 259 ids). 288 -> 313 CAFD ids, 222,677 -> 248,830 function names, 460,904 -> 530,396 value names. Adds early G-chassis ECUs (G011, G030, G038, G001) and RR11. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
From `python ocm/untrimmed.py stats`. The coverage chart and the 89% figure are left alone: they need a rebuild against current psdzdata. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Owner
|
Thank you, this is a great contribution! Merged, and the new names are already out to everyone as definitions 2026.11.18.1 through Check for updates. The pack-caf command is a really useful addition too. Good catch on older versions renaming bits within the same layout, I'll keep that in mind for older cars. |
shamair28
added a commit
that referenced
this pull request
Nov 18, 2026
…11.18.1) Recounted per main series from the CAFD ids in psdzdata after PR #4's packages (313 CAFD ids): G-chassis 67% -> 84% of CAFD ids (120 of 143), F-chassis 52% -> 94% (240 of 254); F001, F010, F025 and F030 at 100%. Verified functions across every G020 and F030 version: about 89% -> 92% (G020 89.3%, F030 97.0%, from definition DBs rebuilt with the new packages). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
shamair28
added a commit
that referenced
this pull request
Nov 18, 2026
…11.18.1) Recounted per main series from the CAFD ids in psdzdata after PR #4's packages (313 CAFD ids): G-chassis 67% -> 84% of CAFD ids (120 of 143), F-chassis 52% -> 94% (240 of 254); F001, F010, F025 and F030 at 100%. Verified functions across every G020 and F030 version: about 89% -> 92% (G020 89.3%, F030 97.0%, from definition DBs rebuilt with the new packages). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First, thank you for building this. I had been planning to make something very similar myself, and when I found Open CAFD Map already doing it (and doing it well), contributing here made a lot more sense than starting a second project.
What this adds
BMW's untrimmed names from older psdzdata and a CAFD dump I had, packed into
definitions/untrimmed/.Most of the new ids are older F-series ECUs (F001, F010, F025, F015, F045, F056), plus I001, K001/KE01, RR01/RR11 and some early G-chassis ECUs (G011, G030, G038, G001). I have not recomputed the coverage chart: its denominators come from your psdzdata, so those numbers are yours to regenerate.
Commits
pack-cafcommand inocm/untrimmed.py(+ one sentence inCONTRIBUTING.md).pack-dumpsonly reads<CafdDefinition>dumps, andbuild_defdb.pyskips function and value names, so there was no way to pack names from a psdzdata that still carries them.pack-cafreads decrypted<caf>XML directly and uses the existingmerge, so the rules are unchanged: existing names win and nothing is removed.Only the packed
.tsv.gzname files are included: no psdzdata, decrypted files, NCDs or VINs.Checks
python ocm/check_names.py: 0 errors (the 5 warnings are existing ones incommunity-cheatsheets).pack-cafon the three sources from a clean checkout ofmaingives byte-identical packages.check_names.py --db(I have no built definition DB on this machine).One thing worth knowing
In about 60 of the ids you already had, the 2014 files name some functions differently from your packages for the same datagroup layout (same address and layout hash). The cases I looked at are BMW renaming or assigning bits between software versions: for example a bit your package calls
UNBELEGTisCDMM_USB_COVER_ARTin older HU_CICHB versions. Since existing names win, your names are kept and the older ones are dropped, so nothing changes for current users. It does mean a layout hash alone cannot tell those versions apart, in case that matters for older cars.Happy to split this up, drop the third commit, or change anything about
pack-cafif you would prefer it done differently.🤖 Generated with Claude Code