Skip to content

fix: validate -s/--start flag and error on unparseable values #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Sladuca merged 2 commits into from
Mar 27, 2026
Merged

fix: validate -s/--start flag and error on unparseable values #259

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
564c511
fix: validate --start flag input and error on unparseable values
Sladuca Mar 27, 2026
39775c2
fix error message
Sladuca Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions src/lib/nodes/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ import utc from "dayjs/plugin/utc.js";
import { parseDurationArgument } from "../../helpers/duration.ts";
import { logAndQuit } from "../../helpers/errors.ts";
import { formatNullableDateRange } from "../../helpers/format-time.ts";
import { parseStartDateOrNow } from "../../helpers/units.ts";

dayjs.extend(utc);
dayjs.extend(timezone);
Expand Down Expand Up @@ -330,11 +329,23 @@ export const maxPriceOption = new Option(
/**
* Common --start option using same parser as buy command
*/
function parseStartDateOrNowOrThrow(val: string): Date | "NOW" {
const nowRe = /\b(?:"|')?[nN][oO][wW](?:"|')?\b/;
if (nowRe.test(val)) return "NOW";
const chronoDate = parseDate(val);
if (!chronoDate) {
logAndQuit(
`Invalid start time: "${val}". Use ISO 8601 format (e.g. '2024-01-15T10:00:00Z'), a relative time (e.g. '+1h'), or 'NOW'.`,
);
}
return chronoDate;
}

export const startOrNowOption = new Option(
"-s, --start <start>",
"Start time (ISO 8601 format:'2022-10-27T14:30:00Z' or relative time like '+1d', or 'NOW')",
)
.argParser(parseStartDateOrNow)
.argParser(parseStartDateOrNowOrThrow)
.default("NOW" as const);

/**
Expand Down
Loading