fix: round max price to integer cents in nodes create#258
Merged
andreaanez merged 1 commit intomainfrom Mar 25, 2026
Merged
Conversation
Fixes floating point precision error when converting dollar price to cents (e.g. 17.60 * 100 = 1760.0000000000002), which caused the API to reject the request. Aligns with the rounding already used in `nodes set` and `nodes extend`. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Review changes with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sf nodes createwhere dollar-to-cents conversion (e.g.17.60 * 100) could produce a non-integer value (1760.0000000000002), causing the API to reject the request with a deserialization errorMath.round()to match the handling already present innodes setandnodes extend