Repository navigation
1.16.2 - #184
Merged
Merged
1.16.2#184
Conversation
Fixes the "Hide Dialog" and "Show Dialog" special validation commands so that they do appear as a validation Error if used in your provisioning. Signed-off-by: Howard Griffith <howardgriffith@yahoo.com>
Signed-off-by: Dan K. Snelson <24623109+dan-snelson@users.noreply.github.com>
Signed-off-by: Dan K. Snelson <24623109+dan-snelson@users.noreply.github.com>
…rInstallomator) Signed-off-by: Dan K. Snelson <24623109+dan-snelson@users.noreply.github.com>
Adds the new Miniaturize (minimize) and Deminiaturize (deminimize) commands added to SwiftDialog to the commands that can be used in Setup-Your-Mac Signed-off-by: Howard Griffith <howardgriffith@yahoo.com>
Command names in swiftDialog were changed from miniaturize and deminiaturize to minimize (or minimise) and maximize (or maximise) Signed-off-by: Howard Griffith <howardgriffith@yahoo.com>
Signed-off-by: Dan K. Snelson <24623109+dan-snelson@users.noreply.github.com>
…into HowardGMac-1.16.2-pr183
Added 'Minimize Dialog' and 'Maximize Dialog' validations for swiftDialog window-state control commands (Pull Request #183; keep ‘em comin’, @HowardGMac) Signed-off-by: Dan K. Snelson <24623109+dan-snelson@users.noreply.github.com>
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The inline policyJSON now maps rosettaInstall to a dialog-control validation that prevents the Jamf trigger from running, and there are additional unnoted default-behavior changes in script parameters.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (4)
What changed in this PR
Release bump to 1.16.2 focusing on swiftDialog 3.1 compatibility, new dialog window-state control validations, and significantly more robust Jamf recon execution/diagnostics, alongside documentation and housekeeping updates across the repo.
Changes:
- Added swiftDialog window-state control validations (Minimize/Maximize) and extended inline
policyJSONdocumentation/examples. - Reworked Jamf
reconexecution to capture exit status, enforce a timeout, and log richer diagnostics (baseline, output excerpts, process snapshots, jamf.log context). - Updated versioned docs/metadata (README/CHANGELOG/AGENTS/etc.) and cleaned validation scripts (BOM removal, safer array iteration).
| File | Description |
|---|---|
| Validations/README.md | Minor docs cleanup in validations overview text. |
| Validations/Microsoft Office 365.bash | Quotes array expansion to preserve full app names during iteration. |
| Validations/CrowdStrike Falcon Status.bash | Removes UTF-8 BOM and normalizes file formatting. |
| Validations/BeyondTrust Privileged Access Management.bash | Removes UTF-8 BOM and normalizes file formatting. |
| Setup-Your-Mac-via-Dialog.bash | Core release changes: version bump, swiftDialog min version, new dialog-control validations, recon hardening, OS/Bash preflight adjustments, policyJSON tweaks. |
| Resources/SYM-Lite.zsh | Adds (and flags as relocated) SYM-Lite script content for reference. |
| Resources/SYM-Lite-README.md | Adds “SYM-Lite has moved” notice and preserves prior guide for reference. |
| Resources/README.md | Adds “SYM-Lite has moved” notice for the Resources folder. |
| README.md | Updates badges/version text and adds SYM-Lite relocation pointer. |
| Prompt-to-Setup-Your-Mac.bash | Updates for Self Service+ (unified logging), adds runAsUser helper, updates icon URL. |
| CONTRIBUTORS.md | Updates contributor heading and adds a contributor acknowledgment. |
| CONTRIBUTING.md | Updates version reference in contributing header. |
| CHANGELOG.md | Adds 1.16.2 release notes and preserves prior entries. |
| AGENTS.md | Updates/expands agent operating contract and validation expectations. |
| .gitignore | Version header bump + adds Codex-related ignores and a deployment script name. |
| .github/ISSUE_TEMPLATE/bug_report.md | Updates script version placeholder for reports. |
| .github/copilot-instructions.md | Adds pointer directing agents to follow AGENTS.md. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
2566
to
2570
| { | ||
| "trigger": "rosettaInstall", | ||
| "validation": "None" | ||
| "validation": "Blurscreen On" | ||
| }, | ||
| { |
Comment on lines
39
to
41
| scriptLog="${4:-"/var/log/org.churchofjesuschrist.log"}" # Parameter 4: Script Log Location [ /var/log/org.churchofjesuschrist.log ] (i.e., Your organization's default location for client-side logs) | ||
| debugMode="${5:-"verbose"}" # Parameter 5: Debug Mode [ verbose (default) | true | false ] | ||
| debugMode="${5:-"false"}" # Parameter 5: Debug Mode [ verbose (default) | true | false ] | ||
| welcomeDialog="${6:-"userInput"}" # Parameter 6: Welcome dialog [ userInput (default) | video | messageOnly | false ] |
| debugMode="${5:-"false"}" # Parameter 5: Debug Mode [ verbose (default) | true | false ] | ||
| welcomeDialog="${6:-"userInput"}" # Parameter 6: Welcome dialog [ userInput (default) | video | messageOnly | false ] | ||
| completionActionOption="${7:-"Restart Attended"}" # Parameter 7: Completion Action [ wait | sleep (with seconds) | Shut Down | Shut Down Attended | Shut Down Confirm | Restart | Restart Attended (default) | Restart Confirm | Log Out | Log Out Attended | Log Out Confirm ] | ||
| completionActionOption="${7:-"wait"}" # Parameter 7: Completion Action [ wait | sleep (with seconds) | Shut Down | Shut Down Attended | Shut Down Confirm | Restart | Restart Attended (default) | Restart Confirm | Log Out | Log Out Attended | Log Out Confirm ] |
Comment on lines
88
to
+89
| # [SYM-Helper] Disables the Blurscreen enabled by default in Production | ||
| moveableInProduction="false" | ||
| moveableInProduction="true" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


21-Sep-2026
Minimize DialogandMaximize Dialogvalidations for swiftDialog window-state control commands (Pull Request 183; keep 'em comin', @HowardGMac!)swiftDialogMinimumRequiredVersionto3.1.0.4994validationkey intrigger_listentries in thepolicyJSON.reconhandling so Setup Your Mac capturesjamf reconexit status, stops forcing verbose inventory output, times out stalled inventory updates, and correctly marks the inventory step failed when Jamf inventory submission fails./bin/bashspecifically.recondiagnostics so timeout and failure logs capture baseline Jamf context, process snapshots, output excerpts, and recentjamf.logdetails, and terminate the complete spawned process tree on timeout.