Skip to content

chore(deps): update dependency @types/node to v22.19.3 #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
renovate merged 1 commit into from
Dec 14, 2025
Merged

chore(deps): update dependency @types/node to v22.19.3 #242

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions npm-shrinkwrap.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"build": "tsc"
},
"devDependencies": {
"@types/node": "22.19.2",
"@types/node": "22.19.3",
"@typescript-eslint/eslint-plugin": "8.49.0",
"@typescript-eslint/parser": "8.49.0",
"eslint": "9.39.2",
Comment on lines 11 to 17
Copy link

@sentry sentry bot Dec 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The DeleteAsset method double-stringifies the event payload by passing a raw JSON string to instanceToPlain instead of a parsed object, corrupting the event data.
Severity: HIGH | Confidence: High

🔍 Detailed Analysis

In the DeleteAsset method, the assetString returned by this.ReadAsset is a JSON string. This string is incorrectly passed directly to instanceToPlain and sortKeysRecursive, which do not parse it. The subsequent call to stringify then double-stringifies the data. This results in the DeleteAsset event being published with a malformed, double-stringified payload (e.g., "{\"ID\":\"asset1\"...}"). While the asset deletion itself succeeds, any downstream event consumers will receive corrupted data, leading to processing failures and data inconsistencies.

💡 Suggested Fix

In the DeleteAsset method, parse the assetString returned from this.ReadAsset using JSON.parse() before passing it to instanceToPlain. This will ensure the asset is treated as an object and serialized correctly for the event payload.

🤖 Prompt for AI Agent 
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: package.json#L11-L17

Potential issue: In the `DeleteAsset` method, the `assetString` returned by
`this.ReadAsset` is a JSON string. This string is incorrectly passed directly to
`instanceToPlain` and `sortKeysRecursive`, which do not parse it. The subsequent call to
`stringify` then double-stringifies the data. This results in the `DeleteAsset` event
being published with a malformed, double-stringified payload (e.g.,
`"{\"ID\":\"asset1\"...}"`). While the asset deletion itself succeeds, any downstream
event consumers will receive corrupted data, leading to processing failures and data
inconsistencies.

Did we get this right? 👍 / 👎 to inform future reviews.
Reference ID: 7487284

Expand Down
Loading