Skip to content

SES-5049 : Invite contacts - Missing qa-tags #1812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jbsession merged 2 commits into from
Jan 6, 2026
Merged

SES-5049 : Invite contacts - Missing qa-tags #1812

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
10b16e6
Added QA tags for manage members and admins menu
jbsession Jan 6, 2026
0b549f2
Merge branch 'dev' into fix/missing-qa-tags
jbsession Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion app/src/main/java/org/thoughtcrime/securesms/groups/ManageGroupAdminsViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,8 @@ class ManageGroupAdminsViewModel @AssistedInject constructor(
// use plural version of this string resource
name = context.resources.getQuantityString(R.plurals.promoteMember, 2, 2),
icon = R.drawable.ic_add_admin_custom,
onClick = ::navigateToPromoteMembers
onClick = ::navigateToPromoteMembers,
qaTag = R.string.qa_manage_members_promote_members
)
)
}
Expand Down
6 changes: 4 additions & 2 deletions app/src/main/java/org/thoughtcrime/securesms/groups/ManageGroupMembersViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,12 +73,14 @@ class ManageGroupMembersViewModel @AssistedInject constructor(
OptionsItem(
name = context.getString(R.string.membersInvite),
icon = R.drawable.ic_user_round_plus,
onClick = ::navigateToInviteContacts
onClick = ::navigateToInviteContacts,
qaTag = R.string.qa_manage_members_invite_contacts
),
OptionsItem(
name = context.getString(R.string.accountIdOrOnsInvite),
icon = R.drawable.ic_user_round_search,
onClick = ::navigateToInviteAccountId
onClick = ::navigateToInviteAccountId,
qaTag = R.string.qa_manage_members_invite_account_id
)
)
}
Expand Down
5 changes: 5 additions & 0 deletions content-descriptions/src/main/res/values/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,6 +274,11 @@
<string name="qa_pro_settings_action_faq">pro-settings-faq</string>
<string name="qa_pro_settings_action_support">pro-settings-support</string>

<!-- Manage members and admin -->
<string name="qa_manage_members_invite_contacts">invite-contacts-menu-option</string>
<string name="qa_manage_members_invite_account_id">invite-accountid-menu-option</string>
<string name="qa_manage_members_promote_members">promote-members-menu-option</string>

<!-- Misc. -->
<string name="AccessibilityId_navigateBack">Navigate back</string>
<string name="AccessibilityId_close">Close Dialog</string>
Expand Down