Enable text-decoration-thickness; more text decoration properties for Blitz - #426
Merged
Merged
Conversation
Loirooriol
requested changes
Jul 13, 2026
nicoburns
force-pushed
the
more-text-decoration-props
branch
2 times, most recently
from
July 17, 2026 13:57
156bfd0 to
819882e
Compare
Loirooriol
reviewed
Jul 19, 2026
nicoburns
force-pushed
the
more-text-decoration-props
branch
from
July 19, 2026 15:23
139ecb1 to
df77127
Compare
Loirooriol
reviewed
Jul 19, 2026
| #[cfg(feature = "servo")] | ||
| #[inline(always)] | ||
| fn parse_thickness() -> bool { | ||
| static_prefs::pref!("layout.unimplemented") |
Collaborator
There was a problem hiding this comment.
At this point, I think you should add a specific pref for this. Gecko used to have layout.css.text-decoration-thickness.enabled. mozilla-firefox/firefox@f4ee21c#diff-fbb611c8fcb79e0ee8911d8e9ce8cbdc8894e04330d01b0f84500c5fcf55b831
Collaborator
Author
There was a problem hiding this comment.
@Loirooriol I've gone ahead and implemented text-decoration-thickness in Servo instead (so we can remove the pref here). All conditional "shorthand" code has been removed from this PR.
nicoburns
changed the title
nicoburns
changed the title
Loirooriol
approved these changes
Jul 22, 2026
Loirooriol
left a comment
Loirooriol
left a comment
Collaborator
There was a problem hiding this comment.
Looks good with nits
…n-inset, and text-decoration-thickness for Blitz Signed-off-by: Nico Burns <nico@nicoburns.com>
Signed-off-by: Nico Burns <nico@nicoburns.com>
Signed-off-by: Nico Burns <nico@nicoburns.com>
Signed-off-by: Nico Burns <nico@nicoburns.com>
nicoburns
force-pushed
the
more-text-decoration-props
branch
from
July 23, 2026 16:59
1786329 to
f4d0976
Compare
pull Bot
pushed a commit
to AKJUS/servo
that referenced
this pull request
Jul 24, 2026
Implement text-decoration-thickness in Servo. Upgrade Stylo to version that enables more text-decoration properties (behind the `layout.unimplemented` flag): - servo/stylo#426 Testing: WPT. There are some new test failures here, but they're all for properties we don't implement yet. --------- Signed-off-by: Nico Burns <nico@nicoburns.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables
text-decoration-thickness,text-decoration-inset,text-underline-offset, andtext-underline-positionfor Servo builds of Stylo, behind thelayout.unimplementedfeature flag.The shorthand
text-decorationis updated to account fortext-decoration-thicknessbeing enabled (this aligns Servo's implementation with Gecko's for this property).Servo PR: