Add remaining preference media queries - #288
Open
lukewarlow wants to merge 15 commits into
Open
Conversation
lukewarlow
force-pushed
the
preference-mqs
branch
from
January 19, 2026 14:34
9d56be2 to
54fa517
Compare
mrobinson
approved these changes
Jan 19, 2026
lukewarlow
force-pushed
the
preference-mqs
branch
2 times, most recently
from
January 28, 2026 14:46
aeb91ff to
f357935
Compare
lukewarlow
force-pushed
the
preference-mqs
branch
from
February 24, 2026 11:15
f357935 to
c85cd37
Compare
Any ancestors of this commit are from upstream mozilla-central, with some filtering and renaming. Our patches and sync tooling start here. The sync tooling has all been squashed into this commit, based on: https://github.com/servo/stylo/commits/64731e10dc8ef87ef52aa2fb9f988c3b2530f3a7
This is a rebase of 2453c41 Signed-off-by: Oriol Brufau <obrufau@igalia.com>
Signed-off-by: Oriol Brufau <obrufau@igalia.com>
Signed-off-by: Oriol Brufau <obrufau@igalia.com>
Signed-off-by: Oriol Brufau <obrufau@igalia.com>
Signed-off-by: Oriol Brufau <obrufau@igalia.com>
Signed-off-by: Oriol Brufau <obrufau@igalia.com>
Signed-off-by: Oriol Brufau <obrufau@igalia.com>
The unit of (1 / 2px) is definitely not a px. Right now we disallow dividing by non-numbers, so enforce it. Once we implement unit math we could start tracking exponents (and support something like squared pixels etc). Differential Revision: https://phabricator.services.mozilla.com/D304694
Servo PR: servo/servo#44978 Signed-off-by: Josh Matthews <josh@joshmatthews.net>
Member
|
We should rebase this change against the latest main branch and merge it. |
We were previously using a mix of f32 and f64. Then it could happen that we would first check that `a < b` in f64, but when converting to f32, they might become equal due to the precision loss. Thus this could break invariants in the logic, making a `debug_unreachable!()` reachable. Servo PR: servo/servo#45682 Signed-off-by: Oriol Brufau <obrufau@igalia.com> Co-authored-by: Martin Robinson <mrobinson@abandonedwig.info>
Reverts servo#368 More work is required in Servo to integrate this.
Fixes servo#390 This feature is quite impactful as it is required for Tailwind's hover styles to work. Servo PR: servo/servo#45681 Signed-off-by: Nico Burns <nico@nicoburns.com>
…servo#388) It's not possible to properly calculate these only looking at style, because the results depends on the used `overflow` value. Servo PR: servo/servo#45629 Signed-off-by: Martin Robinson <martin@abandonedwig.info>
This adds `prefers-contrast`, `prefers-reduced-motion`, and `prefers-reduced-transparency`. Signed-off-by: Luke Warlow <lwarlow@igalia.com>
lukewarlow
force-pushed
the
preference-mqs
branch
from
June 16, 2026 15:34
c85cd37 to
6b61e58
Compare
Member
Author
|
Fingers crossed this is rebased correctly. |
nicoburns
approved these changes
Jun 16, 2026
nicoburns
left a comment
nicoburns
left a comment
Collaborator
There was a problem hiding this comment.
Rebase looks good to me :)
(but I'll hold off on merging until the Servo PR is updated and green)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds
prefers-contrast,prefers-reduced-motion, andprefers-reduced-transparency.Servo PR: servo/servo#42011