chore: add native deduplication to flake checks#330
chore: add native deduplication to flake checks#330weriomat wants to merge 1 commit intoserokell:masterfrom
Conversation
this should fix [serokell#318](serokell#318) by deduplicating the flake paths with a Hashset
Sntx626
left a comment
There was a problem hiding this comment.
This does not de-duplicate all flake checks, just flake checks from having the same node provided multiple times...
What is the use-case for this?
|
Currently, if I deploy multiple nodes from a single repo (i.e. |
Sntx626
left a comment
There was a problem hiding this comment.
I see, in this case I partially misunderstood the purpose of this PR in my previous comment.
I tested this after applying #341 to be able to pass multiple deployment --targets.
It works as described, though it still evaluates the same flake for multiple hosts.
Fixes the problem described.
LGTM
|
Hey what exactly do you mean by evaluating? Evaluating the configuration of the particular host, i.e. the system config or doing the |
|
I'm getting multiple evaluations of the same flake ( I'm referring to the multiple evaluations that should also be able to be de-duplicated, since one evaluation per flake should result in all nodes. |
|
That is a misconception on your part. For each node/ profile the nixosConfiguration (via. outputs.nixosConfiguration.config.system.build.toplevel`) is evaluated in that step. As deploy-rs does not know anything about this configuration it cannot assume that the configuration is the same across the nodes/ profiles. |
this should fix #318 by deduplicating the flake paths with a Hashset