Open
Conversation
its only used for generating system dependant outputs. it would have made more sense to use if systems were provided as a systems were provided as an input.
jalil-salame
approved these changes
Apr 26, 2025
trueNAHO
suggested changes
Oct 16, 2025
trueNAHO
left a comment
trueNAHO
left a comment
There was a problem hiding this comment.
it would have made more sense to use if systems were provided as a systems were provided as an input.
The currently pending commit 428b3a5 ("Add systems input to leverage extensible flake systems pattern") from #345 does exactly that. Thus, superseding this PR.
Interfacing the systems input is required to resolve #209.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
its only used for generating system dependant outputs. it would have made more sense to use if systems were provided as a systems were provided as an input.