ci(build): let the plugin-jar allowlist accept the web app's directory layout - #82
Merged
Merged
Conversation
…y layout The release PR to main failed Build plugin with 121 legitimate entries listed as unexpected: the allowlist admitted only flat jcef/*.js|html and jcef/css/*.css, and since 6.0.0 the web app lives in directories by family (controllers, core, models, views, css/views/...). The pattern now accepts subdirectories while still demanding the js, html and css extensions, so a stray map, doc or fixture under resources/jcef keeps failing the build. Checked against the local 6.0.0 zip: 0 unexpected entries, 126 jcef files, all js, html or css.
Owner
Author
|
This Release is being driven by Claude Code Native Plugin. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Unblocks #80 at
Build plugin. The stepAssert the plugin jar carries only what it shouldadmitted only flatjcef/*.js|htmlandjcef/css/*.css; since 6.0.0 the web app lives in directories by family, so 121 legitimate entries came out as unexpected. The pattern now accepts subdirectories while still demanding thejs,htmlandcssextensions (css only underjcef/css/), so a stray map, doc or fixture underresources/jcefkeeps failing the build.One line in
.github/workflows/ci.yml, on Lain's instruction.Checklist
jcef/files, all js, html or css.Notes for reviewers
Opened, commented, watched and merged from inside the IDE through the plugin's own
pull_request_opstools.