build(verifier): stop failing verifyPlugin on optional dependencies a target IDE lacks - #81
Merged
Merged
Conversation
… target IDE lacks The develop-to-main release PR went red on Plugin verifier with all eight targets Compatible: PyCharm has no com.intellij.modules.java, the optional dependency behind the uast domain, and the IntelliJ Platform Gradle plugin (2.16.0, 2.18.1 alike) parses the verifier's output by the "Missing dependencies" heading without telling an optional gap from a mandatory one. With FailureLevel.MISSING_DEPENDENCIES on, every optional dependency a target lacks is a failed verification. The protection that level gave, a mandatory dependency the IDE cannot satisfy means the plugin never loads, moves to PluginDependenciesContractTest: every non-optional <depends> must be a platform module every IntelliJ-based IDE ships, every optional one names an existing config-file, and the level stays out of failureLevel until the Gradle plugin ships its "missing mandatory" verdict marker. verifyPlugin now passes locally with the Java dependency declared: 8 of 8 Compatible, 42 experimental API usages, no deprecated or internal API.
Owner
Author
|
This Release is being driven by Claude Code Native Plugin. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Unblocks #80.
Plugin verifierfailed there with all eight targetsCompatible: PyCharm lackscom.intellij.modules.java, the optional dependency behind the uast domain, and the IntelliJ Platform Gradle plugin (2.16.0, 2.18.1 alike) parses the verifier's output by theMissing dependenciesheading without telling an optional gap from a mandatory one.FailureLevel.MISSING_DEPENDENCIESleavesfailureLevel.PluginDependenciesContractTestkeeps the protection: every non-optional<depends>is a platform module every IntelliJ-based IDE ships, every optional one names an existing config-file, and the level stays out until the Gradle plugin ships itsmissing mandatoryverdict marker.Checklist
verifyPluginlocally with the Java dependency declared: 8 of 8 Compatible, 42 experimental API usages, no deprecated or internal API.Notes for reviewers
Opened, commented, watched and merged from inside the IDE through the plugin's own
pull_request_opstools.