fix(tabs): hide the closing chat before it leaves the card deck - #70
Merged
serialexperimentslainnnn merged 6 commits intoAug 30, 2026
Merged
Conversation
Closing the last chat logged "Already disposed" from JBCefOsrComponent's resize alarm. Container.remove runs removeNotify() on the card first, then hands it to CardLayout.removeLayoutComponent, which calls next() when the card is still visible. With one card left, next() picks that same card, makes it visible again and validates, so the layout reshapes a browser component whose alarm the removeNotify had already disposed. With two or more chats the survivor's select() had already hidden the dying card, so next() never ran — which is why only the last tab, on a session whose browser had really been realised, hit it.
The listed address was wrong; the maintainer reads lain@digitalexperiments.dev.
Neither is a chore file. CLAUDE.md holds the standing directive over the security code and its tests, and .gitignore is what keeps credentials and local state out of the history; an edit to either changes the rules, so both are listed rather than left to the default glob.
FAQ.md and TROUBLESHOOTING.md still described the 5.5.0 scope. Since 5.7.0 settings are one document per IDE installation, per project, with the old global document kept as the seed — which README.md already says.
serialexperimentslainnnn
force-pushed
the
fix/last-chat-tab-already-disposed
branch
from
August 30, 2026 19:46
eb89371 to
45184a6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug
Closing the last chat tab logged
java.lang.Throwable: Already disposedfromJBCefOsrComponent's resize alarm — only when that chat's session had really been used.ChatTabsPanel.closeremoved the card from theCardLayoutwhile it was still visible.Container.removerunsremoveNotify()first (disposing the browser's resize alarm), thenCardLayout.removeLayoutComponent, which callsnext(parent)if the card is still showing. With a single card,next()picks(i + 1) % 1— the card being removed — makes it visible again and validates, so the layout reshapes a browser whose alarm is already gone.With two or more chats,
select(survivor)had already hidden the dying card viacards.show, sonext()never ran. That is why only the last tab, on a realised browser, hit it.The fix
Hide the card before it leaves the deck, so
removeLayoutComponentnever entersnext(). A no-op on the multi-tab path.Tests
Two new cases in
ChatTabsCloseHeadlessTest; the last-tab one fails without the fix (13 tests completed, 1 failed) and passes with it. Full./gradlew testgreen.Also in this branch
CLAUDE.mdand.gitignorenow owned outright.