Repository navigation
Complete documentation and packaging housekeeping - #43
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a3efc22477
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| recursive-include docs *.md *.tex *.pdf | ||
| recursive-include examples *.md *.json *.csv |
There was a problem hiding this comment.
Include linked docs and example assets in the sdist
For source distributions, these patterns include the README, docs, and example READMEs but omit files those included docs depend on: docs/figures/*.png is referenced by the README and the LaTeX manual source, while docs/run_manifest_template.md links to examples/run_manifest_template.yml, and the reproducible example README points to regenerate.py and expected_tree.txt. An unpacked sdist therefore has broken documentation/reproducibility instructions despite this manifest being added to preserve those materials; include the linked asset/script/template extensions as well.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Thanks — valid finding.
Summary
Completes the final documentation and packaging housekeeping pass for the current LDSFL-Meander maintenance sequence.
Documentation
docs/index.mdas a grouped entry point for user, validation, and maintainer documentation;README.md;Packaging and metadata
pyproject.toml;buildandtwineto the development dependencies;CITATION.cffwith given names, repository metadata, and the Zenodo concept DOI;MANIFEST.inso source distributions retain the citation, manuals, example inputs, and research-software documentation;ldsfl-runentry point;Regression coverage
Adds
tests/test_project_metadata.pyto verify:pyproject.toml,ldsfl.__version__,CITATION.cff, and the README badge;Why
The numerical and user-interface maintenance work is now complete, but the repository still had several housekeeping gaps:
This PR closes those gaps without changing solver mathematics or runtime behaviour.
Validation
A short solver smoke test remains recommended after reinstalling the wheel:
python -m run_ldsfl --base-dir . --cases 1 --max-steps 1 --no-plots --erosion-rate 1e-8Compatibility
0.6.5.1.0e-8.Notes
This is the final patch-12 housekeeping PR. It intentionally avoids: