Deduplicate mode machinery - #40
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Deduplicates the shared modal root/coefficient machinery used by the free and periodic flow-field solvers.
Changed
ldsfl/modes.pyldsfl/flowfield.pyldsfl/flowfield_periodic.pytests/test_mode_machinery_deduplication.pyWhy
The free and periodic flow solvers duplicated the same mode machinery: quartic root solving, MATLAB-compatible root ordering, modal coefficient precomputation, and resonance flagging.
That duplication is risky after the recent resonance work because a future fix to one flow path could silently leave the other path inconsistent. A single shared implementation makes the numerical convention easier to audit and keeps the free and periodic paths aligned.
Validation
python -m py_compile ldsfl/modes.py ldsfl/flowfield.py ldsfl/flowfield_periodic.py tests/test_mode_machinery_deduplication.py python -m pytest tests/test_mode_machinery_deduplication.py tests/test_resonance_diagnostics.py python -m pytest python -m run_ldsfl --base-dir . --cases 1 --max-steps 100 --no-plotsNotes
This is a refactor-only PR.
It does not change the morphodynamic update algorithm, curvature calculation, flow-field convolution implementation, resonance mathematics, stability diagnostics, CLI interface, GUI interface, output naming, fixture structure, or generated output format.