Preserve blank GUI equivalence transient step - #38
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserves a blank GUI equivalence transient-step field when saving GUI configs.
Changed
gui_ldsfl.py_raw_tk_string(...)for config-saving paths where blank values are meaningful;gui_state["sinuo_equiv_transient_step"]to preserve the raw field value instead of falling back to"40000".tests/test_gui_sinuosity_metrics.py_safe_tk_string(...)behaviour unchanged for live diagnostic defaults.Why
Codex correctly flagged that PR #37 saved a blank “Equiv. transient step” GUI field as
"40000".In this field, blank is meaningful:
_build_config()converts it toNone, which requests all-history equivalence analysis. Saving it as"40000"means that loading the saved GUI config would silently change the diagnostic window back to post-40000-only analysis.This follow-up preserves the user’s blank value during config saving while keeping the safe defaulting behaviour for live diagnostic calculations.
Validation
python -m py_compile gui_ldsfl.py tests/test_gui_sinuosity_metrics.py python -m pytest tests/test_gui_sinuosity_metrics.py tests/test_gui_equivalence_controls.py python -m pytest python -m run_ldsfl --base-dir . --cases 1 --max-steps 100 --no-plotsNotes
This is a targeted PR #37 follow-up.
It does not change the solver algorithm, flow solvers, curvature calculation, stability estimator mathematics, CLI interface, output naming, fixture structure, or generated output format.