Add periodic-vs-free validation test - #33
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a dedicated validation test comparing the periodic flow solver against the free-flow solver for a spatially periodic curvature field.
Changed
tests/test_periodic_vs_free_convergence.pyparall_u_periodic(...)andparall_u_free(...);Why
The periodic boundary-condition path has been identified as needing dedicated validation against a trusted reference.
For a spatially periodic curvature field, the periodic solution should match the far-field/interior limit of the free-flow solution when the free-flow domain is sufficiently long. This PR adds that validation as a regression test rather than relying only on solver smoke tests.
The test deliberately checks convergence with increasing domain length, because shorter domains can still be dominated by inlet/outlet effects and are not a meaningful periodic-reference comparison.
Validation
python -m py_compile tests/test_periodic_vs_free_convergence.py python -m pytest tests/test_periodic_vs_free_convergence.py python -m pytest python -m run_ldsfl --base-dir . --cases 1 --max-steps 100 --no-plotsNotes
This is a tests-only PR.
It does not change the morphodynamic update algorithm, flow solvers, curvature calculation, stability diagnostics, CLI interface, GUI interface, output naming, or generated output format.