fix(skills): expand SKILLS_CATALOG to 63 — TUI picker missed v6.50/v6.51 skills (v6.51.1)#197
Merged
Merged
Conversation
….51 skills (v6.51.1) User-reported regression: install-time skills picker showed only 24 legacy skills, missing all 39 net-new skills added in v6.50.0 + v6.51.0 (humanizer + 38 marketingskills). Root cause: scripts/lib/skills.sh:SKILLS_CATALOG is a hand-maintained bash array used as single source of truth for the install TUI. The previous 3 ships updated manifest.json:skills_pins + manifest.json:files.skills_marketplace + templates/skills-catalog.json + mirror dirs, but did NOT update SKILLS_CATALOG. Silent drift — make check does not enforce SKILLS_CATALOG ↔ manifest consistency. Fixed: - scripts/lib/skills.sh:SKILLS_CATALOG expanded from 24 → 63 names. 63 = 62 mirrored skills (matches manifest.json:files.skills_marketplace 1:1) + `impeccable` npm-installed special-case (special-cased in _skills_description, not vendored under templates/skills-marketplace/). - Updated header docstring + skills_catalog_names docstring — no more "24" hardcoded references. - Updated install.sh:1282 comment likewise. Memory correction: v6.51.0 CHANGELOG claimed ab-test-setup was retained from mysticaltech fork. Re-audit shows ab-test-setup was never in skills_pins (only analytics-tracking was kept from mysticaltech). The ab-test-setup claim was a documentation hallucination. SKILLS_CATALOG fix in this release does NOT add ab-test-setup because no mirror dir exists for it. Follow-up: future release should add a make-check gate comparing SKILLS_CATALOG against manifest.json:files.skills_marketplace. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
S1 catalog-correctness and S6 dry-run-row-count were pinned to the pre-v6.50 24-skill catalog. After v6.50 (humanizer +1) and v6.51 (marketingskills +38) the catalog has 63 entries with ab-testing as the new alphabetical first. - S1: 24→63 entries; first ai-models→ab-testing; last index 23→62 - S6: would-install row count 24→63 - Header comments + CONTEXT.md sample-skills note updated Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
User-reported regression. Install-time skills picker showed only the legacy 24 skills, missing all 39 net-new skills from v6.50.0 (
humanizer) + v6.51.0 (38 marketingskills).Root cause
scripts/lib/skills.sh:SKILLS_CATALOGis a hand-maintained bash array used as the single source of truth for the install TUI checklist. The previous 3 ships updated everything except this array:manifest.json:skills_pins— 62 entriesmanifest.json:files.skills_marketplace— 62 entriestemplates/skills-catalog.json— 61+1 (memo-skill no-upstream)templates/skills-marketplace/scripts/lib/skills.sh:SKILLS_CATALOG— stuck at 24Silent drift.
make checkdoes NOT enforceSKILLS_CATALOG ↔ manifestconsistency.Fixed
scripts/lib/skills.sh:SKILLS_CATALOGexpanded24 → 63. 63 = 62 mirrored skills (matchesmanifest.json:files.skills_marketplace1:1) +impeccablenpm-installed special-case (not vendored undertemplates/skills-marketplace/).skills_catalog_names()docstring — no more "24" hardcoded references.install.sh:1282comment likewise.Memory correction
The v6.51.0 CHANGELOG + topic memory file claimed
ab-test-setupwas retained from the mysticaltech fork "under a distinct name." Re-audit showsab-test-setupwas never inskills_pins— onlyanalytics-trackingwas kept from mysticaltech. Theab-test-setupclaim was a documentation hallucination. This release does NOT addab-test-setupto SKILLS_CATALOG because no mirror dir exists for it.Follow-up
Future release should add a
make checkgate that comparesSKILLS_CATALOGagainstmanifest.json:files.skills_marketplace. Tracked as deferred work.Test plan
make check— passes (all gates green, DESK-04 gate 59 skills PASS)SKILLS_CATALOGcount = 63 =ls templates/skills-marketplace | wc -l+ 1 (impeccable)set(SKILLS_CATALOG) - {impeccable}==set(mirror dirs)(no diff)🤖 Generated with Claude Code