Merged
Conversation
1. Provides proper support for attributes. 2. Provides support for empty elements. 3. Adds support for using Xml attributes in deserialization
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the XML deserialization logic to improve correctness and robustness, especially around handling attributes, self-closing elements, and end-element consumption. The changes also add test coverage for a common XML pattern involving lists of elements with only attributes.
Deserializer logic improvements
DeserializeTypeto use an explicit state machine for attribute and element reading, improving clarity and correctness when handling attributes and self-closing elements. The attribute lookup now supports both standard property info and XML attribute/element annotations.Attribute and element handling
Test coverage