Skip to content

chore: Update and pin GitHub Actions, fix zizmor security findings - #40

Merged
ewels merged 2 commits into
mainfrom
better-gha
Aug 18, 2026
Merged

chore: Update and pin GitHub Actions, fix zizmor security findings#40
ewels merged 2 commits into
mainfrom
better-gha

Conversation

@ewels

@ewels ewels commented Aug 18, 2026

Copy link
Copy Markdown
Member

Summary

  • Updates actions/checkout, actions/upload-artifact, and thollander/actions-comment-pull-request to their latest releases, all pinned by commit SHA (via actions-up)
  • thollander/actions-comment-pull-request v2 → v3.0.1 renamed comment_tag to comment-tag; both usages updated accordingly
  • Fixes all zizmor (including --pedantic) findings on the workflows:
    • persist-credentials: false on checkout
    • Explicit least-privilege permissions: blocks (workflow-level contents: read, job-level elevation only where needed)
    • concurrency groups on both workflows
    • Avoided template-injection pattern by passing steps.runfails.outcome through an env: var instead of interpolating directly in a run: block

Test plan

  • zizmor --pedantic . reports no findings
  • CI workflow runs successfully on this PR

Bumps actions/checkout, actions/upload-artifact, and
thollander/actions-comment-pull-request (v2 to v3, renaming
comment_tag to comment-tag) to their latest versions, pinned by SHA.

Also addresses zizmor findings: persist-credentials: false on
checkout, explicit least-privilege permissions blocks, concurrency
groups, and avoiding template injection by passing step outputs
through env vars instead of inline expression interpolation.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown

❌ Pipeline launch failed

The pipeline launch failed. Check the logs uploaded as an artifact for more information.

@ewels
ewels merged commit 2edd5d3 into main Aug 18, 2026
1 check failed
@ewels
ewels deleted the better-gha branch August 18, 2026 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants